Browse Source

Update to-do notes

master
Patrick Lühne 2 years ago
parent
commit
047e03a40a
Signed by: patrick GPG Key ID: 05F3611E97A70ABF
  1. 0
      github-fast-env.rb
  2. 3
      github-fast-envd.rb

0
github-fast-env.rb

3
github-fast-envd.rb

@ -92,6 +92,7 @@ def set_up_named_pipes(control_socket, connection_id)
stdout = open_pipe("#{pipe_base_path}.stdout")
stderr = open_pipe("#{pipe_base_path}.stderr")
# TODO: support script arguments
control_socket.puts "named-pipes #{pipe_base_path_encoded}"
stdin = File.open(stdin, "r")
@ -200,10 +201,8 @@ while true
raise ClientScriptError.new error
end
rescue ClientScriptError => error
# TODO: Restore pipes to make sure that syntax errors are caught
encoded_error_output = Base64.encode64(error.source.full_message).delete("\n")
$original_stderr.puts " error executing script, ignoring request"
# TODO: if the begin/rescue blog has syntax errors, these go unnoticed
begin
control_socket.puts "script_error #{encoded_error_output}"
rescue

Loading…
Cancel
Save