patrick/github-fast-envd
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update to-do notes

Browse Source
This commit is contained in:
Patrick Lühne 2020-05-26 03:22:16 +02:00
parent 02e03156ab
commit 047e03a40a
Signed by: patrick
GPG Key ID: 05F3611E97A70ABF
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
github-fast-env.rb Executable file → Normal file
View File

3
github-fast-envd.rb Executable file → Normal file
View File

@ -92,6 +92,7 @@ def set_up_named_pipes(control_socket, connection_id)
stdout = open_pipe("#{pipe_base_path}.stdout") stdout = open_pipe("#{pipe_base_path}.stdout")
stderr = open_pipe("#{pipe_base_path}.stderr") stderr = open_pipe("#{pipe_base_path}.stderr")
# TODO: support script arguments
control_socket.puts "named-pipes #{pipe_base_path_encoded}" control_socket.puts "named-pipes #{pipe_base_path_encoded}"
stdin = File.open(stdin, "r") stdin = File.open(stdin, "r")
@ -200,10 +201,8 @@ while true
raise ClientScriptError.new error raise ClientScriptError.new error
end end
rescue ClientScriptError => error rescue ClientScriptError => error
# TODO: Restore pipes to make sure that syntax errors are caught
encoded_error_output = Base64.encode64(error.source.full_message).delete("\n") encoded_error_output = Base64.encode64(error.source.full_message).delete("\n")
$original_stderr.puts " error executing script, ignoring request" $original_stderr.puts " error executing script, ignoring request"
# TODO: if the begin/rescue blog has syntax errors, these go unnoticed
begin begin
control_socket.puts "script_error #{encoded_error_output}" control_socket.puts "script_error #{encoded_error_output}"
rescue rescue