plasp/lib/pddlparse/tests/TestIssues.cpp

#include <catch.hpp>

#include <experimental/filesystem>

#include <pddlparse/AST.h>
#include <pddlparse/Parse.h>

namespace fs = std::experimental::filesystem;

const pddl::Context::WarningCallback ignoreWarnings = [](const auto &, const auto &){};

////////////////////////////////////////////////////////////////////////////////////////////////////

TEST_CASE("[PDDL parser issues] Check past issues", "[PDDL parser issues]")
{
	pddl::Tokenizer tokenizer;
	pddl::Context context(std::move(tokenizer), ignoreWarnings);

	SECTION("white space issues with constants and parsing unsupported sections")
	{
		const auto domainFile = fs::path("data") / "issues" / "issue-1.pddl";
		context.tokenizer.read(domainFile);
		CHECK_NOTHROW(pddl::parseDescription(context));
	}

	SECTION("white space issues with empty n-ary predicates")
	{
		const auto domainFile = fs::path("data") / "issues" / "issue-2.pddl";
		context.tokenizer.read(domainFile);
		CHECK_NOTHROW(pddl::parseDescription(context));
	}

	SECTION("comments are correctly ignored")
	{
		const auto domainFile = fs::path("data") / "issues" / "issue-3.pddl";
		context.tokenizer.read(domainFile);
		CHECK_NOTHROW(pddl::parseDescription(context));
	}

	// Check that no infinite loop occurs
	SECTION("“either” in typing section")
	{
		const auto domainFile = fs::path("data") / "issues" / "issue-7.pddl";
		context.tokenizer.read(domainFile);
		CHECK_THROWS(pddl::parseDescription(context));
	}

	// Check that whitespace is correctly ignored in type section
	SECTION("whitespace in typing section")
	{
		const auto domainFile = fs::path("data") / "issues" / "issue-8.pddl";
		context.tokenizer.read(domainFile);
		CHECK_NOTHROW(pddl::parseDescription(context));
	}

	// Check that accidentally unnamed variables lead to an exception and not a segfault
	SECTION("whitespace in typing section")
	{
		const auto domainFile = fs::path("data") / "issues" / "issue-9.pddl";
		context.tokenizer.read(domainFile);
		CHECK_THROWS(pddl::parseDescription(context));
	}

	// Check that “at” is allowed as a predicate name and not exclusively for “at” expressions
	SECTION("“at” as predicate name")
	{
		const auto domainFile = fs::path("data") / "issues" / "issue-10.pddl";
		context.tokenizer.read(domainFile);

		const auto description = pddl::parseDescription(context);

		REQUIRE(description.problem);

		const auto &problem = description.problem.value();
		const auto &facts = problem->initialState.facts;

		const auto invalidFact = std::find_if(facts.cbegin(), facts.cend(),
			[](const auto &fact)
			{
				return
					fact.template is<pddl::ast::AtPointer<pddl::ast::Literal>>()
					|| (fact.template is<pddl::ast::AtomicFormula>() && fact.template get<pddl::ast::AtomicFormula>().template is<pddl::ast::UnsupportedPointer>());
			});

		const auto containsInvalidFact = (invalidFact != facts.cend());

		CHECK(!containsInvalidFact);
	}
}