Rename variable for consistency

This commit is contained in:
Patrick Lühne 2020-05-11 03:12:50 +02:00
parent 17d2373e0d
commit ee1539e2ab
Signed by: patrick
GPG Key ID: 05F3611E97A70ABF
1 changed files with 106 additions and 95 deletions

View File

@ -13,7 +13,7 @@ pub(crate) fn display_domain(domain: crate::Domain) -> DomainDisplay
impl std::fmt::Debug for DomainDisplay impl std::fmt::Debug for DomainDisplay
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
let domain_name = match self.domain let domain_name = match self.domain
{ {
@ -21,15 +21,15 @@ impl std::fmt::Debug for DomainDisplay
crate::Domain::Program => "object", crate::Domain::Program => "object",
}; };
write!(format, "{}", domain_name) write!(formatter, "{}", domain_name)
} }
} }
impl std::fmt::Display for DomainDisplay impl std::fmt::Display for DomainDisplay
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{:?}", &self) write!(formatter, "{:?}", &self)
} }
} }
@ -58,9 +58,9 @@ impl<'a, 'b, C> std::fmt::Debug for FunctionDeclarationDisplay<'a, 'b, C>
where where
C: crate::traits::InputConstantDeclarationDomain C: crate::traits::InputConstantDeclarationDomain
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{}:", self.function_declaration.name)?; write!(formatter, "{}:", self.function_declaration.name)?;
let domain = self.context.input_constant_declaration_domain(self.function_declaration); let domain = self.context.input_constant_declaration_domain(self.function_declaration);
let domain_identifier = match domain let domain_identifier = match domain
@ -73,18 +73,18 @@ where
if self.function_declaration.arity > 0 if self.function_declaration.arity > 0
{ {
write!(format, " (")?; write!(formatter, " (")?;
for _ in 0..self.function_declaration.arity for _ in 0..self.function_declaration.arity
{ {
write!(format, "{}object", separator)?; write!(formatter, "{}object", separator)?;
separator = " * "; separator = " * ";
} }
write!(format, ") >")?; write!(formatter, ") >")?;
} }
write!(format, " {}", domain_identifier) write!(formatter, " {}", domain_identifier)
} }
} }
@ -92,9 +92,9 @@ impl<'a, 'b, C> std::fmt::Display for FunctionDeclarationDisplay<'a, 'b, C>
where where
C: crate::traits::InputConstantDeclarationDomain C: crate::traits::InputConstantDeclarationDomain
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{:?}", &self) write!(formatter, "{:?}", &self)
} }
} }
@ -109,34 +109,34 @@ pub(crate) fn display_predicate_declaration<'a>(
impl<'a> std::fmt::Debug for PredicateDeclarationDisplay<'a> impl<'a> std::fmt::Debug for PredicateDeclarationDisplay<'a>
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{}:", self.0.name)?; write!(formatter, "{}:", self.0.name)?;
let mut separator = ""; let mut separator = "";
if self.0.arity > 0 if self.0.arity > 0
{ {
write!(format, " (")?; write!(formatter, " (")?;
for _ in 0..self.0.arity for _ in 0..self.0.arity
{ {
write!(format, "{}object", separator)?; write!(formatter, "{}object", separator)?;
separator = " * "; separator = " * ";
} }
write!(format, ") >")?; write!(formatter, ") >")?;
} }
write!(format, " $o") write!(formatter, " $o")
} }
} }
impl<'a> std::fmt::Display for PredicateDeclarationDisplay<'a> impl<'a> std::fmt::Display for PredicateDeclarationDisplay<'a>
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{:?}", &self) write!(formatter, "{:?}", &self)
} }
} }
@ -168,7 +168,7 @@ where
C: crate::traits::VariableDeclarationDomain C: crate::traits::VariableDeclarationDomain
+ crate::traits::VariableDeclarationID + crate::traits::VariableDeclarationID
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
let id = self.context.variable_declaration_id(self.variable_declaration); let id = self.context.variable_declaration_id(self.variable_declaration);
let domain = self.context.variable_declaration_domain(self.variable_declaration) let domain = self.context.variable_declaration_domain(self.variable_declaration)
@ -180,7 +180,7 @@ where
crate::Domain::Program => "X", crate::Domain::Program => "X",
}; };
write!(format, "{}{}", prefix, id + 1) write!(formatter, "{}{}", prefix, id + 1)
} }
} }
@ -189,9 +189,9 @@ where
C: crate::traits::VariableDeclarationDomain C: crate::traits::VariableDeclarationDomain
+ crate::traits::VariableDeclarationID + crate::traits::VariableDeclarationID
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{:?}", &self) write!(formatter, "{:?}", &self)
} }
} }
@ -219,7 +219,7 @@ where
C: crate::traits::VariableDeclarationDomain C: crate::traits::VariableDeclarationDomain
+ crate::traits::VariableDeclarationID + crate::traits::VariableDeclarationID
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
let display_variable_declaration = |variable_declaration| let display_variable_declaration = |variable_declaration|
display_variable_declaration(variable_declaration, self.context); display_variable_declaration(variable_declaration, self.context);
@ -227,21 +227,23 @@ where
match &self.term match &self.term
{ {
foliage::Term::Boolean(true) => write!(format, "$true"), foliage::Term::Boolean(true) => write!(formatter, "$true"),
foliage::Term::Boolean(false) => write!(format, "$false"), foliage::Term::Boolean(false) => write!(formatter, "$false"),
foliage::Term::SpecialInteger(foliage::SpecialInteger::Infimum) => write!(format, "c__infimum__"), foliage::Term::SpecialInteger(foliage::SpecialInteger::Infimum) =>
foliage::Term::SpecialInteger(foliage::SpecialInteger::Supremum) => write!(format, "c__supremum__"), write!(formatter, "c__infimum__"),
foliage::Term::SpecialInteger(foliage::SpecialInteger::Supremum) =>
write!(formatter, "c__supremum__"),
foliage::Term::Integer(value) => match value.is_negative() foliage::Term::Integer(value) => match value.is_negative()
{ {
true => write!(format, "$uminus({})", -value), true => write!(formatter, "$uminus({})", -value),
false => write!(format, "{}", value), false => write!(formatter, "{}", value),
}, },
foliage::Term::String(_) => panic!("strings not supported in TPTP"), foliage::Term::String(_) => panic!("strings not supported in TPTP"),
foliage::Term::Variable(variable) => foliage::Term::Variable(variable) =>
write!(format, "{:?}", display_variable_declaration(&variable.declaration)), write!(formatter, "{:?}", display_variable_declaration(&variable.declaration)),
foliage::Term::Function(function) => foliage::Term::Function(function) =>
{ {
write!(format, "{}", function.declaration.name)?; write!(formatter, "{}", function.declaration.name)?;
assert!(function.declaration.arity == function.arguments.len(), assert!(function.declaration.arity == function.arguments.len(),
"function has a different number of arguments than declared (expected {}, got {})", "function has a different number of arguments than declared (expected {}, got {})",
@ -249,38 +251,47 @@ where
if function.arguments.len() > 0 if function.arguments.len() > 0
{ {
write!(format, "{}(", function.declaration.name)?; write!(formatter, "{}(", function.declaration.name)?;
let mut separator = ""; let mut separator = "";
for argument in &function.arguments for argument in &function.arguments
{ {
write!(format, "{}{:?}", separator, display_term(&argument))?; write!(formatter, "{}{:?}", separator, display_term(&argument))?;
separator = ", "; separator = ", ";
} }
write!(format, ")")?; write!(formatter, ")")?;
} }
Ok(()) Ok(())
}, },
foliage::Term::BinaryOperation(foliage::BinaryOperation{operator: foliage::BinaryOperator::Add, left, right}) foliage::Term::BinaryOperation(foliage::BinaryOperation{
=> write!(format, "$sum({:?}, {:?})", display_term(left), display_term(right)), operator: foliage::BinaryOperator::Add, left, right}) =>
foliage::Term::BinaryOperation(foliage::BinaryOperation{operator: foliage::BinaryOperator::Subtract, left, right}) write!(formatter, "$sum({:?}, {:?})", display_term(left), display_term(right)),
=> write!(format, "$difference({:?}, {:?})", display_term(left), display_term(right)), foliage::Term::BinaryOperation(foliage::BinaryOperation{
foliage::Term::BinaryOperation(foliage::BinaryOperation{operator: foliage::BinaryOperator::Multiply, left, right}) operator: foliage::BinaryOperator::Subtract, left, right}) =>
=> write!(format, "$product({:?}, {:?})", display_term(left), display_term(right)), write!(formatter, "$difference({:?}, {:?})", display_term(left),
foliage::Term::BinaryOperation(foliage::BinaryOperation{operator: foliage::BinaryOperator::Divide, ..}) display_term(right)),
=> panic!("division not supported with TPTP output"), foliage::Term::BinaryOperation(foliage::BinaryOperation{
foliage::Term::BinaryOperation(foliage::BinaryOperation{operator: foliage::BinaryOperator::Modulo, ..}) operator: foliage::BinaryOperator::Multiply, left, right}) =>
=> panic!("modulo not supported with TPTP output"), write!(formatter, "$product({:?}, {:?})", display_term(left), display_term(right)),
foliage::Term::BinaryOperation(foliage::BinaryOperation{operator: foliage::BinaryOperator::Exponentiate, ..}) foliage::Term::BinaryOperation(foliage::BinaryOperation{
=> panic!("exponentiation not supported with TPTP output"), operator: foliage::BinaryOperator::Divide, ..}) =>
foliage::Term::UnaryOperation(foliage::UnaryOperation{operator: foliage::UnaryOperator::Negative, argument}) panic!("division not supported with TPTP output"),
=> write!(format, "$uminus({:?})", display_term(argument)), foliage::Term::BinaryOperation(foliage::BinaryOperation{
foliage::Term::UnaryOperation(foliage::UnaryOperation{operator: foliage::UnaryOperator::AbsoluteValue, ..}) operator: foliage::BinaryOperator::Modulo, ..}) =>
=> panic!("absolute value not supported with TPTP output"), panic!("modulo not supported with TPTP output"),
foliage::Term::BinaryOperation(foliage::BinaryOperation{
operator: foliage::BinaryOperator::Exponentiate, ..}) =>
panic!("exponentiation not supported with TPTP output"),
foliage::Term::UnaryOperation(foliage::UnaryOperation{
operator: foliage::UnaryOperator::Negative, argument}) =>
write!(formatter, "$uminus({:?})", display_term(argument)),
foliage::Term::UnaryOperation(foliage::UnaryOperation{
operator: foliage::UnaryOperator::AbsoluteValue, ..}) =>
panic!("absolute value not supported with TPTP output"),
} }
} }
} }
@ -290,9 +301,9 @@ where
C: crate::traits::VariableDeclarationDomain C: crate::traits::VariableDeclarationDomain
+ crate::traits::VariableDeclarationID + crate::traits::VariableDeclarationID
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{:?}", self) write!(formatter, "{:?}", self)
} }
} }
@ -321,8 +332,7 @@ where
+ crate::traits::VariableDeclarationDomain + crate::traits::VariableDeclarationDomain
+ crate::traits::VariableDeclarationID + crate::traits::VariableDeclarationID
{ {
// TODO: rename format to formatter fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
let display_variable_declaration = |variable_declaration| let display_variable_declaration = |variable_declaration|
display_variable_declaration(variable_declaration, self.context); display_variable_declaration(variable_declaration, self.context);
@ -352,30 +362,30 @@ where
if notation == crate::OperatorNotation::Prefix if notation == crate::OperatorNotation::Prefix
{ {
write!(format, "{}(", operation_identifier)?; write!(formatter, "{}(", operation_identifier)?;
} }
match is_left_term_arithmetic && !is_right_term_arithmetic match is_left_term_arithmetic && !is_right_term_arithmetic
{ {
true => write!(format, "f__integer__({})", display_term(left))?, true => write!(formatter, "f__integer__({})", display_term(left))?,
false => write!(format, "{}", display_term(left))?, false => write!(formatter, "{}", display_term(left))?,
} }
match notation match notation
{ {
crate::OperatorNotation::Prefix => write!(format, ", ")?, crate::OperatorNotation::Prefix => write!(formatter, ", ")?,
crate::OperatorNotation::Infix => write!(format, " {} ", operation_identifier)?, crate::OperatorNotation::Infix => write!(formatter, " {} ", operation_identifier)?,
} }
match is_right_term_arithmetic && !is_left_term_arithmetic match is_right_term_arithmetic && !is_left_term_arithmetic
{ {
true => write!(format, "f__integer__({})", display_term(right))?, true => write!(formatter, "f__integer__({})", display_term(right))?,
false => write!(format, "{}", display_term(right))?, false => write!(formatter, "{}", display_term(right))?,
} }
if notation == crate::OperatorNotation::Prefix if notation == crate::OperatorNotation::Prefix
{ {
write!(format, ")")?; write!(formatter, ")")?;
} }
Ok(()) Ok(())
@ -385,7 +395,7 @@ where
{ {
foliage::Formula::Exists(exists) => foliage::Formula::Exists(exists) =>
{ {
write!(format, "?[")?; write!(formatter, "?[")?;
let mut separator = ""; let mut separator = "";
@ -394,17 +404,17 @@ where
let parameter_domain = self.context.variable_declaration_domain(parameter) let parameter_domain = self.context.variable_declaration_domain(parameter)
.expect("unspecified variable domain"); .expect("unspecified variable domain");
write!(format, "{}{:?}: {}", separator, display_variable_declaration(parameter), write!(formatter, "{}{:?}: {}", separator,
display_domain(parameter_domain))?; display_variable_declaration(parameter), display_domain(parameter_domain))?;
separator = ", " separator = ", "
} }
write!(format, "]: ({:?})", display_formula(&exists.argument))?; write!(formatter, "]: ({:?})", display_formula(&exists.argument))?;
}, },
foliage::Formula::ForAll(for_all) => foliage::Formula::ForAll(for_all) =>
{ {
write!(format, "![")?; write!(formatter, "![")?;
let mut separator = ""; let mut separator = "";
@ -413,18 +423,19 @@ where
let parameter_domain = self.context.variable_declaration_domain(parameter) let parameter_domain = self.context.variable_declaration_domain(parameter)
.expect("unspecified variable domain"); .expect("unspecified variable domain");
write!(format, "{}{:?}: {}", separator, display_variable_declaration(parameter), write!(formatter, "{}{:?}: {}", separator,
display_domain(parameter_domain))?; display_variable_declaration(parameter), display_domain(parameter_domain))?;
separator = ", " separator = ", "
} }
write!(format, "]: ({:?})", display_formula(&for_all.argument))?; write!(formatter, "]: ({:?})", display_formula(&for_all.argument))?;
}, },
foliage::Formula::Not(argument) => write!(format, "~{:?}", display_formula(argument))?, foliage::Formula::Not(argument) =>
write!(formatter, "~{:?}", display_formula(argument))?,
foliage::Formula::And(arguments) => foliage::Formula::And(arguments) =>
{ {
write!(format, "(")?; write!(formatter, "(")?;
let mut separator = ""; let mut separator = "";
@ -432,16 +443,16 @@ where
for argument in arguments for argument in arguments
{ {
write!(format, "{}{:?}", separator, display_formula(argument))?; write!(formatter, "{}{:?}", separator, display_formula(argument))?;
separator = " & " separator = " & "
} }
write!(format, ")")?; write!(formatter, ")")?;
}, },
foliage::Formula::Or(arguments) => foliage::Formula::Or(arguments) =>
{ {
write!(format, "(")?; write!(formatter, "(")?;
let mut separator = ""; let mut separator = "";
@ -449,19 +460,19 @@ where
for argument in arguments for argument in arguments
{ {
write!(format, "{}{:?}", separator, display_formula(argument))?; write!(formatter, "{}{:?}", separator, display_formula(argument))?;
separator = " | " separator = " | "
} }
write!(format, ")")?; write!(formatter, ")")?;
}, },
foliage::Formula::Implies(foliage::Implies{antecedent, implication, ..}) foliage::Formula::Implies(foliage::Implies{antecedent, implication, ..})
=> write!(format, "({:?} => {:?})", display_formula(antecedent), => write!(formatter, "({:?} => {:?})", display_formula(antecedent),
display_formula(implication))?, display_formula(implication))?,
foliage::Formula::IfAndOnlyIf(arguments) => match arguments.len() foliage::Formula::IfAndOnlyIf(arguments) => match arguments.len()
{ {
0 => write!(format, "$true")?, 0 => write!(formatter, "$true")?,
_ => _ =>
{ {
let mut separator = ""; let mut separator = "";
@ -473,19 +484,19 @@ where
{ {
if let Some(next_argument) = argument_iterator.peek() if let Some(next_argument) = argument_iterator.peek()
{ {
write!(format, "{}", separator)?; write!(formatter, "{}", separator)?;
if parentheses_required if parentheses_required
{ {
write!(format, "(")?; write!(formatter, "(")?;
} }
write!(format, "{:?} <=> {:?}", display_formula(argument), write!(formatter, "{:?} <=> {:?}", display_formula(argument),
display_formula(next_argument))?; display_formula(next_argument))?;
if parentheses_required if parentheses_required
{ {
write!(format, ")")?; write!(formatter, ")")?;
} }
separator = " & "; separator = " & ";
@ -515,21 +526,21 @@ where
foliage::Formula::Compare( foliage::Formula::Compare(
foliage::Compare{operator: foliage::ComparisonOperator::NotEqual, left, right}) foliage::Compare{operator: foliage::ComparisonOperator::NotEqual, left, right})
=> display_compare(left, right, crate::OperatorNotation::Infix, "!=", None)?, => display_compare(left, right, crate::OperatorNotation::Infix, "!=", None)?,
foliage::Formula::Boolean(true) => write!(format, "$true")?, foliage::Formula::Boolean(true) => write!(formatter, "$true")?,
foliage::Formula::Boolean(false) => write!(format, "$false")?, foliage::Formula::Boolean(false) => write!(formatter, "$false")?,
foliage::Formula::Predicate(predicate) => foliage::Formula::Predicate(predicate) =>
{ {
write!(format, "{}", predicate.declaration.name)?; write!(formatter, "{}", predicate.declaration.name)?;
if !predicate.arguments.is_empty() if !predicate.arguments.is_empty()
{ {
write!(format, "(")?; write!(formatter, "(")?;
let mut separator = ""; let mut separator = "";
for argument in &predicate.arguments for argument in &predicate.arguments
{ {
write!(format, "{}", separator)?; write!(formatter, "{}", separator)?;
let is_argument_arithmetic = let is_argument_arithmetic =
crate::is_term_arithmetic(argument, self.context) crate::is_term_arithmetic(argument, self.context)
@ -537,14 +548,14 @@ where
match is_argument_arithmetic match is_argument_arithmetic
{ {
true => write!(format, "f__integer__({})", display_term(argument))?, true => write!(formatter, "f__integer__({})", display_term(argument))?,
false => write!(format, "{}", display_term(argument))?, false => write!(formatter, "{}", display_term(argument))?,
} }
separator = ", " separator = ", "
} }
write!(format, ")")?; write!(formatter, ")")?;
} }
}, },
} }
@ -559,8 +570,8 @@ where
+ crate::traits::VariableDeclarationDomain + crate::traits::VariableDeclarationDomain
+ crate::traits::VariableDeclarationID + crate::traits::VariableDeclarationID
{ {
fn fmt(&self, format: &mut std::fmt::Formatter) -> std::fmt::Result fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result
{ {
write!(format, "{:?}", self) write!(formatter, "{:?}", self)
} }
} }