patrick/plasp
Archived
1
0
Fork 0
Code Issues 12 Releases 8 Activity

Minor refactoring removing unnecessary temporary variable.

Browse Source
This commit is contained in:
Patrick Lühne 2016-06-08 01:31:14 +02:00
parent 069ad4ca99
commit 42559fd601
2 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/plasp/pddl/Action.h
View File

@ -31,7 +31,7 @@ class Action
const Expression &effect() const;
private:
Action(std::string name);
Action() = default;
std::string m_name;

17
src/plasp/pddl/Action.cpp
View File

@ -21,18 +21,11 @@ namespace pddl
//
////////////////////////////////////////////////////////////////////////////////////////////////////
Action::Action(std::string name)
: m_name{name}
{
}
////////////////////////////////////////////////////////////////////////////////////////////////////
void Action::parseDeclaration(Context &context, Domain &domain)
{
const auto actionName = context.parser.parseIdentifier(isIdentifier);
auto action = std::make_unique<Action>(Action());
auto action = std::make_unique<Action>(Action(actionName));
action->m_name = context.parser.parseIdentifier(isIdentifier);
context.parser.expect<std::string>(":parameters");
context.parser.expect<std::string>("(");
@ -49,11 +42,9 @@ void Action::parseDeclaration(Context &context, Domain &domain)
{
context.parser.expect<std::string>(":");
const auto sectionIdentifier = context.parser.parseIdentifier(isIdentifier);
if (sectionIdentifier == "precondition")
if (context.parser.probe<std::string>("precondition"))
action->m_precondition = parsePreconditionExpression(context, expressionContext);
else if (sectionIdentifier == "effect")
else if (context.parser.probe<std::string>("effect"))
action->m_effect = parseEffectExpression(context, expressionContext);
context.parser.skipWhiteSpace();